All Heroes for Hire from the Tavern have the entire army

ApocalypticDoomsayer · April 24, 2023, 4:54pm

How does the problem look like?

Not sure if this is a bug, but it is at least different from the original game (to which im not agreeing; personally, i like it this way).

In the original game, after you buy the first 2 heroes, all other heroes have 1 stack of 1 level 1 un upgraded creature.

In this version, however, all heroes have full starting army.

In addition, last week the first two heroes were (probably coincidentally) Castle heroes.

This week, only the 4 and 5th heroes were Castle. Is this normal? I think a system similar to Heroes 4 should be implemented in the future. Why would an Inferno Hero be available in Castle?
Is there a place to discuss these kind of things?

What exactly did you do to trigger it?

Open Taven in Town View and buy heroes.

A screenshot or video would be fantastic.

Self-Explanatory

HeroWO · April 25, 2023, 12:57pm

Wow, I didn’t know this. I thought all heroes you hire except those who’ve fled start with the usual army. Added a to-do note for the future.

Currently, each player has a list of heroes available for hire and the “native” town (usually the one selected in Advanced Options when starting a game). The list is populated according to the native town and probabilities from HCTRAITS.TXT:

It’s true that those probabilities seem odd so databank.php tweaks them a bit:

github.com

HeroWO-js/Core/blob/55cafe3d581000a1ae5c1a9b8fb3730c4bb95fb1/databank/databank.php#L2633-L2642


      
          // In HCTRAITS.TXT these numbers expectedly sum up to 100, just not by rows (for a given town, all classes have 100 in total).
          // However, the difference between 6 and 5 (the only used values)
          // seems to be way less than it appears in the game (you will hardly see a hero with "chance 5") so we're adjusting 5% to 2.5% and 6 to 8%; given that all classes use exactly ten 6%-s and eight 5%-s, we still get a round number: 10*8+8*2.5.
          $line[] = array_map(function ($v) {
            return [5 => 2.5, 6 => 8][$v];
          }, array_splice($line, -9));
          
          $idName = HeroClass::makeIdentifier(array_shift($line));
          $skillChances = array_combine($skills, array_splice($line, 14, -1));
          $obj = new HeroClass(array_combine(columnsOf(HeroClass::class, '*townChances'), $line));

That said, the population algorithm is here:

github.com

HeroWO-js/Core/blob/55cafe3d581000a1ae5c1a9b8fb3730c4bb95fb1/client/H3.Rules.js#L5386


      
          // ($ifObject) by tavernHeroes Effects. SoD rules are (determined empirically):
          //* Available hero pool is one for all taverns for a given player
          //* Standalone taverns on the map use the pool of the visiting player
          //* Keep at least 2 heroes available for hire at all times, and ensure no two identical Hero->$id are offered
          //  (for one player or for all players as one, it's not clear)
          //* Randomize heroes every 7 days (on Mondays); nevermind if a hero is removed and random immediately selects adding another hero of the same class (Hero->$id)
          //* When own hero surrenders or retreats, replace a random available hero in the pool (most of the time 2nd) with the defeated one
          //* When hiring a hero, generate a new hero; hero removal (due to regeneration or hiring) is permanent
          //* Even if a player has no towns, if he has two heroes, one is defeated and another immediately captures a town - he can recruit the defeated hero
          // However, sometimes the game breaks these rules. For example, it occasionally randomizes one hero at any day, or defers making a retreated hero available for days or even weeks.
          _initializePlayers: function () {
            var size = 2    // XXX=RH to databank
          
            // Missing in AObject: id, mirrorX, mirrorY, x, y, z, displayOrder,
            // owner and the remainder to the bottom.
            var atter = this.classes.atter([
              // XXX=R:clc:
              'type', 'texture', 'animation', 'duration', 'width', 'height', 'miniMap', 'passableType', 'passable', 'actionable', 'actionableFromTop'])
          
            var players = this.map.players.omit('0')

Yep, 🇬🇧 General.

HeroWO · May 18, 2023, 8:53pm

This was made more in line with HoMM 3 after @Vladimir has pointed out the algorithm from FizMig. No native hero in tavern on the first day